search

ravendb / ravendb-php-client

MIT License
6 stars 4 forks source link

RDBC-628 #29

Closed alxsabo closed 1 year ago

alxsabo commented 1 year ago

https://issues.hibernatingrhinos.com/issue/RDBC-628/PHP-Client-select-fields-additional-assemblies

ppekrol commented 1 year ago

@alxsabo Env variables are not passed to PRs by design (they will be passed to runs made on branch). In other repositories (e.g. C#) we do have an attribute to handle those kinds of tests. https://github.com/ravendb/ravendb/blob/v5.4/test/Tests.Infrastructure/LicenseRequiredFactAttribute.cs

ml054 commented 1 year ago

In Java we have this https://github.com/ravendb/ravendb-jvm-client/blob/v5.4/src/test/java/net/ravendb/client/infrastructure/DisableOnPullRequestCondition.java

ml054 commented 1 year ago

In general you should detect if we have env variable defined if no then skip test. I can see phpunut has $this->markTestSkipped