search

ravendb / ravendb.contrib

External Contributions to RavenDB
http://ravendb.net
MIT License
30 stars 14 forks source link

RavenDB hook for MiniProfiler #2

Closed CMircea closed 11 years ago

CMircea commented 11 years ago

It is not that elegant (queries show up as "sql", query types aren't... too helpful, etc.), but it gets the job done. Uses the JSON formatter from the RavenDB MVC profiler.

Just call RavenProfiler.InitializeFor(store) in your application startup, after you've initialized the store of course.

mattjohnsonpint commented 11 years ago

Since you're taking on a new dependency, please create it in a new project. Raven.Client.Contrib.MiniProfiler.csproj. Be sure to target .net 4.0 in the new project.

Everything else looks good. and Thanks!!!

mattjohnsonpint commented 11 years ago

I will (at some point) write some guidelines for contribution. I'd accept it as-is were it not for the dependency. Not everyone that grabs the contrib library will also want miniprofiler.

CMircea commented 11 years ago

I've split the profiler into another project. How do I add another commit to the pull request... or better, how do I reopen it? Kinda new to GitHub (and git overall).

mattjohnsonpint commented 11 years ago

It's probably easiest just to create a new pull request like you did the first time.