search

ravendb / samples-yabt

"Yet Another Bug Tracker" solution sample for RavenDB and .NET with Angular UI
https://yabt.ravendb.net
MIT License
109 stars 22 forks source link

[Backend] Db Server Stats #32

Closed yj7o5 closed 2 years ago

yj7o5 commented 3 years ago

partially closes #10

yj7o5 commented 3 years ago

@AKlaus created as draft at-the-moment since I haven't fully tested it yet. You can go ahead and provide any remarks if you want.

AKlaus commented 3 years ago

Hi @yj7o5, Thank you for submitting a PR. I'll write notes on the files and some here when they're applicable to multiple files.

  1. Need automated tests to cover the new functionality. We aren't aiming 100% coverage but the main goal is to ensure that the feature works in principle and all fragile bits (usually, integration points) a covered by tests
  2. All the new DTOs shouldn't be added to Database.Common project (it's a shared project with common classes between Database and Domain, see the diagram here). The best way would be to add another service to Domain project (e.g. call it ServerStatsService). Put all the DTOs into a subfolder of the service folder.
  3. The preferable way to communicate with the server by using the existing IDocumentStore rather than via HTTP. See this link.
yj7o5 commented 3 years ago

Thanks @AKlaus will go ahead and perform the changes.

AKlaus commented 2 years ago

Closing it, as it appears abandoned by the submitter (idle for more than a year)