search

ravendb / serilog-sinks-ravendb

A Serilog sink that writes events to RavenDB
Apache License 2.0
17 stars 16 forks source link

Add support for expiration bundle. Allow user to set default databas… #1

Closed tcabanski closed 8 years ago

tcabanski commented 8 years ago

…e when configuring seilog to allow for case where using embedded wihtout a default databse at the connection level.

Because this is currently referencing the 2.5 version of the RavenDB client, I had to use a non-async method to get metadata. If we upgrade to 3.0, there is an async version of that method. If you would like me to upgrade the library as part of this pull request, please let me know.

Note that I allow for the default database to be set to allow my use of the lib in an application that uses an embedded database. My connection needs to point at the system database to allow the application to create a tenant database with proper settings. Therefore, I need a way to pass the tenant to the sink.

nblumhardt commented 8 years ago

Looks good Tom!

If it would be better if we upgrade to Raven.Client v3, let's do that? Seems like it'd be widely useful, anyway.

A couple of other comments in there. Cheers!

tcabanski commented 8 years ago

Clearly, I broke something at AppVeyor. It claims it cannot load nunit though it did download the package. I tried bumping up to 2.6.4 with no success. I don't have access to troubleshoot so need your advice here.

tcabanski commented 8 years ago

Never mind. Once I corrected the version conflict with Newtonsoft all was fine.

nblumhardt commented 8 years ago

:+1: great, thanks Tom!