search

ravendb / serilog-sinks-ravendb

A Serilog sink that writes events to RavenDB
Apache License 2.0
17 stars 16 forks source link

Allow to run on RavenDB 4.1 #5

Closed ayende closed 5 years ago

ayende commented 5 years ago

Most of the actual work is here: b12fc85

The rest is just craft for the version updates.

Didn't touch the docs / release scripts.

nblumhardt commented 5 years ago

Hey Oren! Thanks for the PR. It's been a long time since I looked at this code - as you would have found, the build and publishing infrastructure is a bit primitive. The CI build for the PR failed with:

Error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "Microsoft.CSharp [4.6.0-preview.18571.3, )" or update the version field in the nuspec.
nblumhardt commented 5 years ago

... (continued). I think master in this repository has rotted for most intents and purposes; I think we should merge this PR and then switch the whole repo to the new CSPROJ setup and build scripts used throughout the rest of the serilog org.

I'll hit the button now, and loop back to fix up the build as soon as I have a moment.

If you'd like to help out, the scripts/YAML/file structure in https://github.com/serilog/serilog-sinks-file is a decent template. Happy to add you as a co-maintainer if you think you'll have any more time to push this project forward (there's currently no active maintainer here).

ayende commented 5 years ago

I'm afraid that I don't have the capacity for more.