search

ravibpatel / ILRepack.Lib.MSBuild.Task

MSBuild task for ILRepack which is an open-source alternative to ILMerge.
Other
107 stars 30 forks source link

Should the NuGet package be marked as a development dependency? #47

Closed Numpsy closed 8 months ago

Numpsy commented 8 months ago

Hi, I tried attaching the ILRepack.Lib.MSBuild.Task nuget package to a project of mine to test, and noticed that my created nuget package has a dependency on ILRepack.Lib.MSBuild.Task itself.

I can add a PrivateAssets="all" to the PackageReference in my project myself to avoid it, but I wonder if nuget package here should maybe have a <developmentDependency>true</developmentDependency> in it so that gets done automatically?

ravibpatel commented 8 months ago

I tried it, and it adds PrivateAssets="all" without specifying the developmentDependency in nuspec for me.

Numpsy commented 8 months ago

Hmm, not sure then. I was F# project with central package version management enabled at the time, I'll try it with something more minimal to check. This was with Visual Studio 2022 17.8.3 for the record.

ravibpatel commented 8 months ago

I added it because it is a developmentDependency after all. Thanks for reporting.

Numpsy commented 8 months ago

Thanks, I tried it with 2.0.26 and it's setting PrivateAssets itself now.