ravibpatel / ILRepack.Lib.MSBuild.Task

MSBuild task for ILRepack which is an open-source alternative to ILMerge.
Other
107 stars 30 forks source link

Repack Drop Attributes not dropped #55

Closed roguesaloon closed 1 month ago

roguesaloon commented 1 month ago

Specified attributes are not dropped when using the RepackDropAttribute property as part of the MSBuild task. This persumably worked at some point (when it was added?), but no longer works with the latest version of ILRepack due to the way the backend is structured (uses RepackDropAttributes HashSet parsed from passed commandline option). I have created and tested a fix for this issue, that aligns closely with the commandline parser in RepackOptions (from IL Repack).

roguesaloon commented 1 month ago

Have raised PR to resolve this issue: https://github.com/ravibpatel/ILRepack.Lib.MSBuild.Task/pull/56

ravibpatel commented 1 month ago

Thanks for the fix. I pushed the updated package to NuGet it should be available soon.