search

ravignir / 5Hex-Tileset

A MASSIVE tileset mod by Ravignir. New tile graphics, new unit graphics. Compatible with: RekMOD, Ancient and Medieval civs mods. Leave a star on the mod page if you like it.
128 stars 16 forks source link

Snow + Hill #1

Closed SomeTroglodyte closed 3 years ago

SomeTroglodyte commented 3 years ago

You'll surely know Unciv now layers well and has hills as feature instead of baseterrain so you could benefit + redesign a few tiles... Even so, the new hills on snow have more problems with 5Hex (read on after the screenshots):

5Hex

image

FantasyHex

image

Fix: Bulk rename Ito i for the Snow png's

        "Snow+Hill": ["Snow","Hill"],
        "Snow+Hill+Coal": ["Snow","Hill","Coal"],

image

Lastly: :+1: :+1: :+1: :+1: :+1: - significantly enhances the fun! What an admirable pile of work!

ravignir commented 3 years ago

This repository still uses old tile layering - so it kinda does work with new unciv versions, but not perfectly. Anyway good catch with the Snow+HIll name, but it does not really matter. There is a new repository that's is the most updated one and fully utilizes new layering and Hills being a feature: https://github.com/ravignir/5HexPlus - you should use it instead. This repository will be soon fully replaced with the new content - but maybe i should do it now?.

SomeTroglodyte commented 3 years ago

Oh, new repo instead of new branch... OK, why not - or does it count players will see an update to the existing mod directly in the mod manager screen? Not that it stands out much, but it's coded. However you choose, keep up the good work!

SomeTroglodyte commented 3 years ago

Yes, 5Hex Plus works fine. But I'd ditch the repo and use the old one for one reason alone: It still appears on the first page while for Plus you need to scroll down all the way after clicking next page once. Also, the description text has more room, perhaps to hint it needs an extra step as 'permament visual mod'...

Btw, the mod manager neither passes any sorting parameter in the github query (if they even exist) nor does it sort github's response. So it's probably ordered by some internal SQL IDENTITY column - first come first serve?

ravignir commented 3 years ago

ok i've copied other repository contents here, and deleted all of the old, redundant sprites. I am open for suggestions which tiles I should redesign :)

SomeTroglodyte commented 3 years ago

Redesign graphics? Dunno whether I haven an eye for that. But if I come across any I'll be sure to tell you. Am thinking more about the mod manager screen code... I saw that you were busy right within Unciv even before the comment mail arrived, so that part was confirmed working :grin: