ravignir / RekMOD

LekMOD for unciv. New and rebalanced civs, buildings, units, mechanics.
104 stars 52 forks source link

Validation issues #121

Closed MakorKa closed 1 year ago

MakorKa commented 1 year ago

After last update has issues with mod. This is text from mods check

Cloves is buildable and therefore must either have an explicit cost or reference an existing tech! Nutmeg is buildable and therefore must either have an explicit cost or reference an existing tech! Pepper is buildable and therefore must either have an explicit cost or reference an existing tech! Palace is buildable and therefore must either have an explicit cost or reference an existing tech! Palace Great Writing Slot is buildable and therefore must either have an explicit cost or reference an existing tech! Royal Library Great Writing Slot is buildable and therefore must either have an explicit cost or reference an existing tech! Great Library Great Writing Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Great Library Great Writing Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Amphitheater Great Writing Slot is buildable and therefore must either have an explicit cost or reference an existing tech! National Epic Great Writing Slot is buildable and therefore must either have an explicit cost or reference an existing tech! Parthenon Great Writing Slot is buildable and therefore must either have an explicit cost or reference an existing tech! Heroic Epic Great Writing Slot is buildable and therefore must either have an explicit cost or reference an existing tech! Oxford University Great Writing Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Oxford University Great Writing Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Opera House Great Music Slot is buildable and therefore must either have an explicit cost or reference an existing tech! Sistine Chapel Great Art Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Sistine Chapel Great Art Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Globe Theatre Great Writing Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Globe Theatre Great Writing Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Hermitage Great Art Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Hermitage Great Art Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Hermitage Great Art Slot 3 is buildable and therefore must either have an explicit cost or reference an existing tech! Uffizi Great Art Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Uffizi Great Art Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Uffizi Great Art Slot 3 is buildable and therefore must either have an explicit cost or reference an existing tech! Museum Great Art Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Museum Great Art Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Louvre Great Art Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Louvre Great Art Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Louvre Great Art Slot 3 is buildable and therefore must either have an explicit cost or reference an existing tech! Louvre Great Art Slot 4 is buildable and therefore must either have an explicit cost or reference an existing tech! Broadcast Tower Great Music Slot is buildable and therefore must either have an explicit cost or reference an existing tech! Broadway Great Music Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Broadway Great Music Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech! Broadway Great Music Slot 3 is buildable and therefore must either have an explicit cost or reference an existing tech! Sydney Great Music Slot 1 is buildable and therefore must either have an explicit cost or reference an existing tech! Sydney Great Music Slot 2 is buildable and therefore must either have an explicit cost or reference an existing tech!

MakorKa commented 1 year ago

Screenshot_20230629-173013 But only one is blocking. This error message shown if try to start new game

**Platform:** Android
**Version:** 4.7.2 (Build 881)
**Rulesets:** [Ukraine Mod, Civ V - Vanilla, RekMOD, AbsoluteUnitsXL, Civ V - Gods & Kings, AbsoluteUnits, Community Maps, Extra Buildings]
**Last Screen:** com.unciv.ui.screens.mainmenuscreen.MainMenuScreen

--------------------------------

Device Model: Pixel 7 Pro
API Level: 33

--------------------------------

**Message:**

com.unciv.logic.UncivShowableException: Building 'Cloves' is buildable and therefore must either have an explicit cost or reference an existing tech.
    at com.unciv.models.ruleset.Ruleset.updateBuildingCosts(Ruleset.kt:461)
    at com.unciv.models.ruleset.RulesetCache.getComplexRuleset(Ruleset.kt:630)
    at com.unciv.models.ruleset.RulesetCache.getComplexRuleset(Ruleset.kt:610)
    at com.unciv.models.ruleset.RulesetCache.getComplexRuleset(Ruleset.kt:592)
    at com.unciv.ui.screens.newgamescreen.NewGameScreen.<init>(NewGameScreen.kt:54)
    at com.unciv.ui.screens.newgamescreen.NewGameScreen.<init>(NewGameScreen.kt:49)
    at com.unciv.ui.screens.mainmenuscreen.MainMenuScreen$newGameButton$1.invoke(MainMenuScreen.kt:154)
    at com.unciv.ui.screens.mainmenuscreen.MainMenuScreen$newGameButton$1.invoke(MainMenuScreen.kt:153)
    at com.unciv.ui.screens.mainmenuscreen.MainMenuScreen$getMenuButton$1.invoke(MainMenuScreen.kt:103)
    at com.unciv.ui.screens.mainmenuscreen.MainMenuScreen$getMenuButton$1.invoke(MainMenuScreen.kt:101)
    at com.unciv.ui.components.input.ActivationActionMap.activate(ActivationActionMap.kt:55)
    at com.unciv.ui.components.input.ActorAttachments.activate(ActorAttachments.kt:40)
    at com.unciv.ui.components.input.ActivationExtensionsKt.activate(ActivationExtensions.kt:17)
    at com.unciv.ui.components.input.ActivationListener.tap(ActivationListener.kt:15)
    at com.badlogic.gdx.scenes.scene2d.utils.ActorGestureListener$1.tap(ActorGestureListener.java:52)
    at com.badlogic.gdx.input.GestureDetector.touchUp(GestureDetector.java:209)
    at com.badlogic.gdx.scenes.scene2d.utils.ActorGestureListener.handle(ActorGestureListener.java:125)
    at com.badlogic.gdx.scenes.scene2d.Stage.touchUp(Stage.java:355)
    at com.unciv.ui.screens.basescreen.UncivStage.access$touchUp$s80204510(UncivStage.kt:17)
    at com.unciv.ui.screens.basescreen.UncivStage$touchUp$1.invoke(UncivStage.kt:87)
    at com.unciv.ui.screens.basescreen.UncivStage$touchUp$1.invoke(UncivStage.kt:87)
    at com.unciv.ui.crashhandling.CrashHandlingExtensionsKt$wrapCrashHandling$1.invoke(CrashHandlingExtensions.kt:17)
    at com.unciv.ui.screens.basescreen.UncivStage.touchUp(UncivStage.kt:87)
    at com.badlogic.gdx.backends.android.DefaultAndroidInput.processEvents(DefaultAndroidInput.java:426)
    at com.badlogic.gdx.backends.android.AndroidGraphics.onDrawFrame(AndroidGraphics.java:472)
    at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1573)
    at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1272)
SomeTroglodyte commented 1 year ago

This has been "solved" - however one may read that word - on Unciv side. One spurious warning remains - "Tech column number 0 has no explicit wonder cost" - and I haven't looked at that yet, I suspect column 0 is unused and the actual techs start in 1, in which case maybe that too should be skipped on Unciv side.