search

ravinasavani / Stickee-Technology---Test

0 stars 0 forks source link

Consistency with spacing and line-breaks around if... else... #1

Open edwardgenochiostickee opened 2 years ago

edwardgenochiostickee commented 2 years ago

Hi Ravina,

Can you improve the consistency in your use of spacing and line breaks in if... else... syntax?

https://github.com/ravinasavani/Stickee-Technology---Test/blob/ae56243d5c3e8565ebb72287d536badb3ab81a27/src/ScrapeHelper.php#L65

Ideally, we encourage you to follow the standards in PSR-12. (https://www.php-fig.org/psr/psr-12/#51-if-elseif-else) But at least: aim for consistency.

ravinasavani commented 2 years ago

Hello,

Thanks for the suggestion. I have formatted the code structure using standards PSR-12. Looking forward to interview.

Thank You, Ravina

On Mon, 4 Jul 2022 at 15:05, edwardgenochiostickee @.***> wrote:

Hi Ravina,

Can you improve the consistency in your use of spacing and line breaks in if... else... syntax?

https://github.com/ravinasavani/Stickee-Technology---Test/blob/ae56243d5c3e8565ebb72287d536badb3ab81a27/src/ScrapeHelper.php#L65

Ideally, we encourage you to follow the standards in PSR-12. ( https://www.php-fig.org/psr/psr-12/#51-if-elseif-else) But at least: aim for consistency.

— Reply to this email directly, view it on GitHub https://github.com/ravinasavani/Stickee-Technology---Test/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQLBO7XH4ND4NLUJYNEXK3VSLVRHANCNFSM52TKCGSA . You are receiving this because you are subscribed to this thread.Message ID: @.***>