search

ravindUwU / firefox-refined-findbar

Refine the Firefox (100–132) find bar by repositioning it, adjusting spacing & styling internal elements.
https://old.reddit.com/r/FirefoxCSS/comments/7fxtdm
MIT License
18 stars 1 forks source link

The padding around the box looks odd #3

Closed neilpat05 closed 2 weeks ago

neilpat05 commented 4 weeks ago

v131.0.3

I'm not a dev, but just tried including this in my userChrome.css file. I am also having Firefox-UI-Fix, so unsure if there is some kind of clash.

image
ravindUwU commented 4 weeks ago

Hi! 😊 I notice your close button has been moved to the the left of the other controls.

Refined findbar adds a padding-inline-start to the findbar, but not a padding-inline–end, because the close button has it's own margin that spaces it out. The fix would probably be to remove the individual margins from immediate children of the findbar and space them out using gap, like how the controls are spaced out already. I'm unable to work on & test this immediately, but will over the next couple weeks.

For an interim fix, you should be able to add a padding-inline-end: math.div($space-unit, 3); after the -start rule and copy it over again 🤔. Here's a playground link; let me know if it works? Thanks!

neilpat05 commented 4 weeks ago

It still looks the same to me, actually. I do want to highlight that I'm not a developer and solely copied that code. Either way, thank you for your help, mate.

I'm unable to work on & test this immediately, but will over the next couple weeks.

I'm glad you responded and tried helping me with an interim fix.

neilpat05 commented 2 weeks ago

Thank you for the support @ravindUwU.

This solved my issue. I just wanted to let you know that the close button is on the left of other controls, even after the update. I'm unsure if that was the intended goal. I'm also using Firefox-UI-Fix.

image
ravindUwU commented 2 weeks ago

Yup! The close button on the left the other controls is probably part of Firefox-UI-Fix 🤔, whereas the fix for this issue simply "resets" the horizontal spacing in between & on either side of those controls, and they seem to work together just fine.

Thanks for confirming! 😄