search

raviqqe / muffet

Fast website link checker in Go
MIT License
2.49k stars 97 forks source link

support http? #11

Closed kybin closed 6 years ago

kybin commented 6 years ago

Thank you @raviqqe . It looks simple and useful.

I checked a http site with muffet.

It works on index page. But it changes the site's links to https.

So it does not found the linked pages.

Do you have plan to add support of http sites?

raviqqe commented 6 years ago

Can you put the link to the website here so that the bug can be reproduced?

kybin commented 6 years ago

Sure.

$ muffet http://lazypic.org

http://lazypic.org/about
    ERROR   https://www.instagram.com/coffeecat_yoonji (invalid status code 404)
http://lazypic.org/catndog
    ERROR   https://www.instagram.com/coffeecat_yoonji (invalid status code 404)
http://lazypic.org/coffeecat
    ERROR   https://www.instagram.com/coffeecat_yoonji (invalid status code 404)
http://lazypic.org
    ERROR   https://www.instagram.com/coffeecat_yoonji (invalid status code 404)
http://lazypic.org/
    ERROR   https://www.instagram.com/coffeecat_yoonji (invalid status code 404)
http://lazypic.org/shortfilms
    ERROR   https://www.instagram.com/coffeecat_yoonji (invalid status code 404)
kybin commented 6 years ago

Ah, sorry. I didn't read it well. It worked well for the first links.

It is still weird result, though.

If you prefer, I will revisit with new issue.

kybin commented 6 years ago

I find my mistake.

I assume it will print OK for valid link. It seems I should put -v flag for that.

Sorry for the confusion!