search

raviqqe / muffet

Fast website link checker in Go
MIT License
2.46k stars 95 forks source link

Make accepted HTTP response status codes configurable #364

Closed pmwmedia closed 4 months ago

pmwmedia commented 4 months ago

This pull request adds a new optional argument --status-codes to make the accepted HTTP response status codes configurable and solves #189 and #291.

I use muffet to check all links on https://tinylog.org/. However, some websites (e.g. https://stackoverflow.com, https://www.baeldung.com, and https://mkyong.com/) respond with status code 403 instead of 200 to muffet. Therefore, I would like to accept 403 as valid HTTP response status code.

pmwmedia commented 4 months ago

Hi @raviqqe,

Can you consider approving the automatic workflow runs? This will allow me to fix any issues that may arise from the workflow runs until you have a chance to review the pull request. If there is anything I can approve, just let me know.

raviqqe commented 4 months ago

Thank you for the changes!

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.58%. Comparing base (61d5451) to head (4a9453e). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #364 +/- ## ========================================== + Coverage 87.50% 88.58% +1.08% ========================================== Files 30 32 +2 Lines 872 727 -145 ========================================== - Hits 763 644 -119 + Misses 88 62 -26 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.