raviqqe / muffet

Fast website link checker in Go
MIT License
2.46k stars 95 forks source link

Clean up deprecated arguments #380

Open vsupalov opened 2 months ago

vsupalov commented 2 months ago

Close #300.

There is a bit of uncertainty. I'm not sure if I understood your intention with deprecating the sitemap flag - my guess is, that the functionality is intended be removed.

If that interpretation is correct, I will add some refactoring to the PR, to make sure the now-unnecessary sitemap related remnants are cleaned up.

raviqqe commented 2 months ago

Thank you for the changes! I'm gonna review this soon.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.68%. Comparing base (61d5451) to head (1fd50a0). Report is 19 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #380 +/- ## ========================================== + Coverage 87.50% 88.68% +1.18% ========================================== Files 30 33 +3 Lines 872 716 -156 ========================================== - Hits 763 635 -128 + Misses 88 60 -28 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.