raviqqe / muffet

Fast website link checker in Go
MIT License
2.46k stars 95 forks source link

muffet treats preconnect hrefs like links #391

Closed movitz-s closed 1 week ago

movitz-s commented 2 weeks ago

Websites often have code like this

<link rel="preconnect" href="https://fonts.googleapis.com">

in order to increase performance. https://fonts.googleapis.com returns 404 but the HTML code is still valid and should not be checked by muffet.

Is this a unknown issue or am I doing something wrong with muffet?
I am willing to implement a fix for this, just lmk.

raviqqe commented 2 weeks ago

You can exclude certain links with --exclude option. Can you try it?

movitz-s commented 2 weeks ago

That is what I've done with the common font providers etc, but it is an imperfect solution since you might not know which domains are used in preconnect. It should be easy to fix for every preconnect link, I can implement it if wanted, as I said.

raviqqe commented 1 week ago

I see. If you can implement it, I appreciate it!