search

raviriley / agency-jekyll-theme

Jekyll version of the newest Agency Bootstrap theme, plus new features: Google Analytics, Markdown support, custom pages, and more!
https://raviriley.github.io/agency-jekyll-theme-starter/
MIT License
347 stars 689 forks source link

Made the header image fixed instead of it being scrolled #25

Closed kotsom closed 3 years ago

kotsom commented 3 years ago

This is an enhancement or feature.

Summary

Jus made the image fixed, for a live demo visit manakairv.com

raviriley commented 3 years ago

That does look good, but I'm not sure if everyone would want that as the default behavior. If you'd like to contribute to the theme, I suggest adding header-image-scrolling to style.yml and making the default scroll but if header-image-scrolling: fixed, then make it fixed. Example:

#Image Customization
header-image: "../img/header.png"
header-image-scrolling: "fixed"
contact-image: "../img/contact.png"
raviriley commented 3 years ago

Added to the Theme Functionality Project Board: https://github.com/raviriley/agency-jekyll-theme/projects/1#card-58273686