raviriley / agency-jekyll-theme

Jekyll version of the newest Agency Bootstrap theme, plus new features: Google Analytics, Markdown support, custom pages, and more!
https://raviriley.github.io/agency-jekyll-theme-starter/
MIT License
347 stars 689 forks source link

No way to edit About #36

Closed Cryptwright closed 3 years ago

Cryptwright commented 3 years ago

The about section just says a title, and then puts the text down twice, once as a subheader and once as the body. I do not see a way to actually create a body of text.

image

When displayed it shows this, repeating the "text" value twice.

image

rbenitezpagan commented 3 years ago

@Cryptwright I submitted Theme PR (https://github.com/raviriley/agency-jekyll-theme/pull/37) and Starter PR (https://github.com/raviriley/agency-jekyll-theme-starter/pull/5) can you try it out? You can do it by changing the remote theme to rbenitezpagan/agency-jekyll-theme until it gets approved here. Update both.

Cryptwright commented 3 years ago

This may fix the other issue, but does not address the fact that the about page does not have a spot in the config.yml to add a body of text. it only shows the subheader twice. Updated my original comment.

rbenitezpagan commented 3 years ago

@Cryptwright you should be able to add text to that section using this variable: https://github.com/raviriley/agency-jekyll-theme-starter/blob/64a4039c8e9fa16b0e1922fb6f933858d67dceaf/_data/sitetext.yml#L73

Please use my remote theme for testing (until the PR is accepted) rbenitezpagan/agency-jekyll-theme

Variable text is not a sub-header to the best of my knowledge.

Cryptwright commented 3 years ago

Please see my revised initial comment. That TEXT variable shows up as a subheader AND as the body, in both places. This makes it unusable as the body.

rbenitezpagan commented 3 years ago

@Cryptwright I fixed it in my repo. Can you try it out? Use my remote theme (for testing) rbenitezpagan/agency-jekyll-theme I added variable body.

image

Cryptwright commented 3 years ago

Does not work yet. I do not see the rendering code in the commit. I see the sitetext file is added to the commit but not whichever file actually renders the page. [I see this now]

I changed this:

image

rbenitezpagan commented 3 years ago

I fixed the theme but you have to also download the fixed theme-starter or manually add the changes to your project.

These are the 2 changed files (you can ignore the Gemfile) https://github.com/raviriley/agency-jekyll-theme-starter/pull/5/files

Cryptwright commented 3 years ago

i see how it should work based on the commits but still can't get it to work by changing my remote theme. i'll keep working on it. thanks!

rbenitezpagan commented 3 years ago

@Cryptwright if you want to make a public version so I can help or add me to your repo temporarily. Let me know.

Cryptwright commented 3 years ago

I got it! I forgot to unset my custom layout to undo my workaround. Works good now.

raviriley commented 3 years ago

Thanks @rbenitezpagan, bug fix will be merged soon @Cryptwright !