search

raviriley / agency-jekyll-theme

Jekyll version of the newest Agency Bootstrap theme, plus new features: Google Analytics, Markdown support, custom pages, and more!
https://raviriley.github.io/agency-jekyll-theme-starter/
MIT License
347 stars 689 forks source link

Ability to override fonts #65

Closed matthewhall79 closed 7 months ago

matthewhall79 commented 1 year ago

I'd like to be able to override the Google fonts used as the first-choice fonts in the font-family attributes in _sass/base/_mixins.scss.

Would you accept a contribution to add this capability? Any thoughts on how you'd prefer to see this done?

Thanks very much for this theme!

raviriley commented 1 year ago

@matthewhall79 feel free to open a PR! Adding options for font customization could potentially be added to style.yml.

th3ass3t commented 1 year ago

@raviriley it appears @matthewhall79 didn't create a pull request from this "bug".

I'm brand spanking new to all things git and floundering all over the place! I had the same issue, as I created the site from the template, which doesn't provide the option to change the fonts.

I tried to "create a pull request" but the interface seems to grey this out, asking me to compare different branches. Altogether confused, but happy to make mistakes and learn.

th3ass3t commented 1 year ago

I tried following this guide, and added a main.scss file to my own repo from the template.. Not sure if it worked yet because I am having other issues :)

raviriley commented 1 year ago

I tried to "create a pull request" but the interface seems to grey this out, asking me to compare different branches. Altogether confused, but happy to make mistakes and learn.

Pull requests are how changes get requested to this repo. In order to make a pull request, you have to "fork" this repo (meaning make your own copy), then make changes to it, then open a pull request to "pull" in the changes you made from your fork to this repo.

raviriley commented 7 months ago

Closed by #78