ravishende / grafana_data_retrieval

2 stars 0 forks source link

Change old_paths.append(new_paths) to after phase_4 is complete rather than after phase_1 #66

Closed ravishende closed 3 months ago

ravishende commented 6 months ago

Currently, there is a line commented out in phase_1 after everything is done. Here is the line: # update old_paths txt to include newly found paths # self._append_txt_file(self.files['old_paths'], new_paths)

However, if there is an unsuccessful new collection of training data, then new_run is set to True, all those runs gathered will be set to old and never gathered again. We should instead switch this line to after phase_4's success flag is set in work_flow.py. After this, then go back and append new paths to old paths.

Once this is fixed, delete the commented out old line from phase_1.py

ravishende commented 3 months ago

It is better to not have old_paths at all, since unless you do a have reset_phases_progress(wipe_paths_gathered=True), which it is False by default, you won't have to regather them ever. And if you do set it to True, you want to be able to regather them, which won't work if they're all in old_paths