ravivooda / stocks

1 stars 0 forks source link

Improvement should have minimum threshold as well #14

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

https://github.com/ravivooda/stocks/blob/1bd24b9fa68b17c88f2d25afb327f732c905d293/insights/overlap/multi_overlaps.go#L25


            }
            holdings, mappedPercentageHoldings := utils.MergeHoldings(combinedPercentageMatrices...)
            overlapAnalysis := g.compare(targetedPercentageMatrix, holdings)
            // TODO: Improvement should have minimum threshold as well
            if int(overlapAnalysis.OverlapPercentage) >= g.c.MergedThreshold {
                var computedOverlaps []models.LETFOverlap
                for _, overlap := range overlapAnalysis.DetailedOverlap {
github-actions[bot] commented 2 years ago

Closed in d2f84af9a1275bfb54a4cdad96a7c49de06b52a1