search

ravmustang / eXpochVectorBuild4Exile

11 stars 14 forks source link

AGLtoASL breaks Exile compatibility #2

Open PrimusNZ opened 6 years ago

PrimusNZ commented 6 years ago

https://github.com/ravmustang/eXpochVectorBuild4Exile/blob/4d433a6df67deacac2652dc3ba9e38c3b551015f/eXile.MAPNAME/eXpochVectorBldg/ExileClient_util_world_canBuildHere.sqf#L80

This line breaks placing items after a restart. Exile uses ASL now for positions. See ExileServer_object_construction_network_buildConstructionRequest _canBuildHereResult = [configName _constructionConfig, ATLtoASL _objectPosition, getPlayerUID _playerObject] call ExileClient_util_world_canBuildHere;

Same with lines https://github.com/ravmustang/eXpochVectorBuild4Exile/blob/4d433a6df67deacac2652dc3ba9e38c3b551015f/eXile.MAPNAME/eXpochVectorBldg/ExileClient_util_world_canBuildHere.sqf#L34 https://github.com/ravmustang/eXpochVectorBuild4Exile/blob/4d433a6df67deacac2652dc3ba9e38c3b551015f/eXile.MAPNAME/eXpochVectorBldg/ExileClient_util_world_canBuildHere.sqf#L38 and https://github.com/ravmustang/eXpochVectorBuild4Exile/blob/4d433a6df67deacac2652dc3ba9e38c3b551015f/eXile.MAPNAME/eXpochVectorBldg/ExileClient_util_world_canBuildHere.sqf#L42

PrimusNZ commented 6 years ago 
Changed: "ExileClient_util_world_canBuildHere" now takes PositionASL instead of PositionAGL for simplification/optimization purposes. If you use this function in custom scripts/addons, make sure to update your code.

http://www.exilemod.com/topic/25026-104-pineapple/

ravmustang commented 6 years ago

Completely agree, its broken! Sorry bud, my compare did not show the util_world_canBuildHere was changed by 1.0.4(DOH!)

Thank you for the report on missing override changes. I will push them ASAP, in the future you are more than welcome to do a pull merge request so that all can see the exact changes needed while I get to the approval 😉

Again, Thanks @PrimusNZ