ravsamhq / notify-slack-action

🔔 Send a Slack Notification from Github Actions regarding failure, warnings, or even success.
https://ravsam.in/blog/send-slack-notification-when-github-actions-fails/
MIT License
173 stars 57 forks source link

Improve message #3

Closed andrii29 closed 3 years ago

andrii29 commented 3 years ago

hi, can you add few improvements to this action?

Regard, Andrii

ravgeetdhillon commented 3 years ago

Hi @andrii29,

I will work on these aspects this weekend. Thanks.

andrii29 commented 3 years ago

hi, one more improvement)

For example, i want to send notifications always, but mentions only on errors.

TY!

ravgeetdhillon commented 3 years ago

Except

Everything has been solved.

ravgeetdhillon commented 3 years ago

This issue has been resolved in release 1.2.0.

andrii29 commented 3 years ago

hi, TY!

one more improvement. Now without specify mention and mention_when I will get message like this image consider update if statement https://github.com/ravsamhq/notify-slack-action/blob/master/main.py#L98 and mention != ''

andrii29 commented 3 years ago

also, please allow to mention teams https://stackoverflow.com/questions/54284389/mention-users-group-via-slack-api

andrii29 commented 3 years ago

one more feature)

ravgeetdhillon commented 3 years ago

Hi @andrii29 .

Please open these requests as a new issue. Thanks for understanding.