Improve message, p2 - Githubissues

ravsamhq / notify-slack-action

🔔 Send a Slack Notification from Github Actions regarding failure, warnings, or even success.

https://ravsam.in/blog/send-slack-notification-when-github-actions-fails/

MIT License

173 stars 57 forks source link

Improve message, p2 #5

Closed andrii29 closed 3 years ago

andrii29 commented 3 years ago

Hello, please improve this action a little bit:

allow to mention teams (https://stackoverflow.com/questions/54284389/mention-users-group-via-slack-api)
put mentions in a new line of message (look's much better than one long lone)
fix empty mentions Now without specify mention and mention_when I will get message like this https://user-images.githubusercontent.com/31315876/114349748-f8ef3200-9b70-11eb-96ea-08c71681a19d.png consider update if statement https://github.com/ravsamhq/notify-slack-action/blob/master/main.py#L98 and mention != ''

Regards, Andrii

ravgeetdhillon commented 3 years ago

This issue has been resolved in release 1.3.0.