search

ravsamhq / notify-slack-action

🔔 Send a Slack Notification from Github Actions regarding failure, warnings, or even success.
https://ravsam.in/blog/send-slack-notification-when-github-actions-fails/
MIT License
173 stars 57 forks source link

Request: Add "skipped" status #73

Closed rdhar closed 2 years ago

rdhar commented 2 years ago

Hi @ravgeetdhillon, many thanks for sharing this super-useful GitHub action with us!

On the job.status, it looks like "skipped" status has been missed out as a potential option. "skipped" is a valid, documented result/conclusion for both jobs and steps contexts so it'd be really appreciated if it could be captured similar to "cancelled".

It might seem odd, but I leverage notify-slack-action@v2 as the last in a chain of jobs which outputs their overall status like shown below. So that how's we can potentially end up with the "skipped" status needing to notify Slack. 

status: ${{ needs.build.result || needs.scan.result || needs.deploy.result }}

Cheers, Rishav

ravgeetdhillon commented 2 years ago

@rdhar This issue has been fixed in the release v2.3.0. Let me know if you are happy with the new changes.

rdhar commented 2 years ago

That's excellent, huge thanks for taking on board the feedback so quickly, massively appreciate it!

image