ravsii / elgo

In-Memory matchmaking based on Elo rating
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Feature: Add socket server and client for remote access #20

Closed ravsii closed 1 year ago

ravsii commented 1 year ago

Closes #5

codecov[bot] commented 1 year ago

Codecov Report

Merging #20 (1bcc7b8) into main (d926162) will decrease coverage by 40.37%. The diff coverage is 36.47%.

:exclamation: Current head 1bcc7b8 differs from pull request most recent head 3d39c83. Consider uploading reports for the commit 3d39c83 to get more accurate results

@@             Coverage Diff              @@
##              main      #20       +/-   ##
============================================
- Coverage   100.00%   59.63%   -40.37%     
============================================
  Files            4        8        +4     
  Lines          151      384      +233     
============================================
+ Hits           151      229       +78     
- Misses           0      153      +153     
- Partials         0        2        +2     
Flag Coverage Δ
unittests 59.63% <36.47%> (-40.37%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
socket/player.go 0.00% <0.00%> (ø)
socket/server.go 0.00% <0.00%> (ø)
socket/client.go 26.96% <26.96%> (ø)
socket/readwriter.go 86.95% <86.95%> (ø)
pool.go 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ravsii commented 1 year ago

This is currently on hold. I'm not very experienced with sockets so I can't understand why some data is getting lost while sending over.