search

ravsii / elgo

In-Memory matchmaking based on Elo rating
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

server and client disconnection bug #45

Closed AHNakbari closed 1 year ago

AHNakbari commented 1 year ago

when disconnect server before the client finish it works or inverse, a lot of errors occurred that spam the log. now just one error that tell us server or client are disconnected

ravsii commented 1 year ago

Hi @splenta22. Thanks for this PR. I was taking a break for a while from git and now I have some free time again, so I'll check as soon as I can. Also I believe this is related to #37

Can you please .idea to gitignore?

On a side note, socket server support is my lowest priority (a lot of edge cases, plus I don't have much experience working with sockets), so if you're actually using it, I'd recommend protobuf or pure in-memory servers/pools, but keep in mind the project is still in the development and barely usable.

AHNakbari commented 1 year ago

In my opinion, Sockets are not that bad, they are traditional, more user-friendly and simpler.