search

ravthan / all-eyes

Automatically exported from code.google.com/p/all-eyes
0 stars 0 forks source link

CodeReview: For file aemgrmgmt.c, should compare with "acceptrc != 1" not "acceptrc <= 0" #51

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
During code review, we found that in file aemgrmgmt.c at line 186,177, the if 
statement is

      int acceptrc = SSL_accept(ssl);
      if (acceptrc <= 0)  {

It should be 

      int acceptrc = SSL_accept(ssl);
      if (acceptrc != 1)  {

Original issue reported on code.google.com by toddd...@gmail.com on 31 Oct 2012 at 1:50

GoogleCodeExporter commented 8 years ago 
Fixed,
ravi.

Original comment by ravt...@gmail.com on 31 Oct 2012 at 4:48

GoogleCodeExporter commented 8 years ago 
Fixed,
ravi.

Original comment by ravt...@gmail.com on 31 Oct 2012 at 4:51

GoogleCodeExporter commented 8 years ago 
Verified with unit testing

Original comment by tbrt....@gmail.com on 9 Dec 2012 at 9:24