search

ravynsoft / Firefox_app

Mozilla Firefox patched for airyxOS with global menu support and packaged as an Application Bundle
11 stars 1 forks source link

'!Firefox' menu #2

Closed probonopd closed 3 years ago

probonopd commented 3 years ago

When running this version of Firefox on helloSystem, I am seeing a "!Firefox" menu before "File".

image

Is this done inside this repo? I'd actually need a version without this.

mszoek commented 3 years ago

Yes - the menus are reorganized by this patch: https://github.com/airyxos/Firefox_app/blob/main/patch-browser_menubar

So just omit that from the build if you don't want the "application" menu. I do need that for airyxOS as it creates the bolded "Firefox" menu with the About/Quit/etc options on it.

probonopd commented 3 years ago

Thank you very much.

probonopd commented 3 years ago

@mszoek since no existing binaries will have that menu in that place, wouldn't be a more sensible approach to re-shuffle the menus on-the-fly when the menubar receives them via D-Bus? Then you would get that extra icon not just for this one app, but for all of them...

probonopd commented 3 years ago

I tried building Firefox on Cirrus CI and from how I read the logs the build "almost" succeeded but not quite: https://cirrus-ci.com/task/5185344850100224?logs=main#L9174

Have you ran into this before?

mszoek commented 3 years ago

@mszoek since no existing binaries will have that menu in that place, wouldn't be a more sensible approach to re-shuffle the menus on-the-fly when the menubar receives them via D-Bus? Then you would get that extra icon not just for this one app, but for all of them...

Possibly, but I am not sure they're deterministic enough to do that reliably. This is just a stop-gap until I can get the Mac version building so I don't plan to spend a lot of effort on it.

mszoek commented 3 years ago

I tried building Firefox on Cirrus CI and from how I read the logs the build "almost" succeeded but not quite: https://cirrus-ci.com/task/5185344850100224?logs=main#L9174

Have you ran into this before?

No... some kind of issue with libpci from the looks of it.

probonopd commented 3 years ago

This is just a stop-gap until I can get the Mac version building

I like that goal setting! :+1: