ravynsoft / ravynos

A BSD-based OS project that aims to provide source and binary compatibility with macOS® and a similar user experience.
https://www.ravynos.com
Other
5.68k stars 192 forks source link

Dock: Display minimized windows. Unminimize if clicked. #345

Closed mszoek closed 3 days ago

ivedantmistry commented 2 years ago

Hello @mszoek can u explain i detail the problem

mszoek commented 2 years ago

Yes! Sorry, I converted these issues from notes in my project board so they are pretty sparse! This one is a to-do item for implementing a behavior in Dock. When an open window is minimized, Dock should display an icon for it, and un-minimize/restore that window if the icon is clicked.

The code that does the actual display and badging of the minimized window icon is there today. The missing piece is to hook into WindowServer and catch minimize/restore events to drive this. You would call this on a minimize event:

https://github.com/ravynsoft/ravynos/blob/72c6d0c4c76581491dbce4e54dfe5c4f6f51a701/CoreServices/Dock/DockItem.m#L53-L55

and if a window is restored externally from Dock, it should also catch that event and remove the minmized window icon for it.

Is that enough explanation?

ivedantmistry commented 2 years ago

out of enthusiasm i commented on your issue, actually i'm totally newbie in this ,i can do so if you give me time and other info to do so thank you and sorry mate

mszoek commented 2 years ago

Sure, go wild. I like enthusiasm :) I probably won't get to doing this myself for a while since I'm working on another area right now, so please feel free to try doing it if you want to!

ivedantmistry commented 2 days ago

sorry that i couldn't solve it🥲

mszoek commented 2 days ago

All good!! Plenty of other tasks if you feel up to taking something on :)