search

rawgraphs / rawgraphs-app

A web interface to create custom vector-based visualizations on top of RAWGraphs core
https://rawgraphs.io
Apache License 2.0
8.66k stars 1.84k forks source link

PWA Support #268

Open edoguido opened 3 years ago

edoguido commented 3 years ago

In which part of the interface would this feature applies?

[ ] 1. Load your data [ ] 2. Choose a chart [ ] 3. Mapping [ ] 4. Customize [ ] 5. Export [x] 6. Other

Is your feature request related to a problem? Please describe. Users cannot access RAW when offline.

Describe the solution you'd like To be able to use RAW as a Progressive Web Application. This lets people use all the features even when no internet connection is available (the app is fully cached thanks to a Service Worker), and in a native-like interface.

Code-wise, it's just about renaming this line into serviceWorker.register(), just like stated in the comments above the line itself.

Once the PWA-enabled version is built, users will see an "Install" button on the rightmost side of the URL bar on major browsers (no Safari, no IE of course).

Additional context image

bianchimro commented 3 years ago

hi @edoguido thanks for the suggestion, makes perfectly sense.

Let's take a look at these considerations: https://create-react-app.dev/docs/making-a-progressive-web-app#offline-first-considerations

to understand if the ui should collaborate in some way with service worker lifecycle

edoguido commented 3 years ago

Hi @bianchimro !

Sorry for the late response.

Yes, we basically need to tell the user when the PWA is ready to be installed, as well as when a new version is available.

I will make mockups for the UI, show you and - if approved - implement code-side in a dedicated fork.

Sounds good?

bianchimro commented 3 years ago

Hi @edoguido, sorry for not updating you on this issue. As this introduces changes in the user experience, we should discuss better the feature with the team. If you want to proceed with a mockup it would help us undertanding the impact.