search

rawgraphs / rawgraphs-charts

A curated selection of charts provided through RAWGraphs interface
https://rawgraphs.io/
Apache License 2.0
95 stars 42 forks source link

peerDependencies #36

Open uf0 opened 4 years ago

uf0 commented 4 years ago

should we add rawgraphs-core as peerDependencies (since is already used in the frontend) or just in devDependencies (since it's needed for the sandbox) or keep it in both?

bianchimro commented 3 years ago

I think devDependencies should be enough.

@gffuma @osioalberto what do you think?

osioalberto commented 3 years ago

In my opinion, it is both dev and peer. It is not a hard dependency since we don't want to bundle it in our distribution (as we use rollup, deps are bundled) It must be a dev because we want it to be automatically installed when we clone the repo to develop some chart. It must be a peer since it is not a bundled dependency but it is used at runtime, so any developer that builds something depending on the charts package must take care of installing core as well.