search

rawgraphs / rawgraphs-charts

A curated selection of charts provided through RAWGraphs interface
https://rawgraphs.io/
Apache License 2.0
92 stars 43 forks source link

'Expand' in Streamgraph doesn't fill the graph 100% vertically sometimes #99

Closed sal-uva closed 2 years ago

sal-uva commented 2 years ago

In which chart does the bug happen?

RAWGraphs Version 2.0

Web browser and version Firefox 91.0.2 (also happens on Chrome)

Operating System Windows 10

Steps to reproduce this Import data -> Select "Streamgraph -> Select "Expand" for "Streams vertical alignment"

Project file streamgraph-bug.rawgraphs.txt

(I added .txt to the .rawgraphs file, else I couldn't upload, just remove it!)

Additional context I'm using YYYY-MM dates, but it seems to persist with other values as well. For me it's most notable with "descending" as a sort value. If I'm correct, the graph should fill out 100% vertically, right? (Thanks for the amazing tool!)

afbeelding

mikima commented 2 years ago

Really strange.

Some of the streams are not drawn with "expand" or "none" options of "Streams vertical alignment", and that cause the white space. For example, filtering the dataset on the letter I only two streams are shown with "expand" and "none" (see images below):

none silhouette wiggle expand I have to further test if it's something related to d3, to rawgraphs or to the dataset. streamgraph-bug-dataset-I.tsv.zip streamgraph-bug-dataset.tsv.zip

sal-uva commented 2 years ago

Fantastic, thank you!

mikima commented 2 years ago

hi @sal-uva, the issue is fixed, but it will be visible from release v1.0.0-beta.23