rawls238 / PlanOut.js

A JavaScript port of Facebook's PlanOut Experimentation Framework
MIT License
308 stars 52 forks source link

Running examples/experiment_verification.js leads to a `throw "IMPLEMENT setup"` error #63

Closed ckuijjer closed 7 years ago

ckuijjer commented 7 years ago

Running the example in _examples/experimentverification.js leads to a throw "IMPLEMENT setup" error.

I've tried fixing this in pull request #62 by adding the extend method as also used in _sample_interpreteres5.js and _sample_planoutes5

rawls238 commented 7 years ago

Ah I forgot about these, they must have not been updated in the update to 4.0. @mattrheault can you take care of this?

mattrheault commented 7 years ago

Fixed in https://github.com/HubSpot/PlanOut.js/pull/64