Open dobesv opened 4 years ago
Seems reasonable, feel free to PR
Yes, at some point we eliminated the magic variable, in experiment. Returning false is the way folks should be disabling logging.
Sent from my iPhone
On Jan 24, 2020, at 5:55 PM, Dobes Vandermeer notifications@github.com wrote:
I believe the PlanOut language expects that if you don't return false then the experiment is considered active.
Currently the interpreter only sets _inExperiment = true if you explicitly return true in the script.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.
I believe the PlanOut language expects that if you don't
return false
then the experiment is considered active.Currently the interpreter only sets
_inExperiment = true
if you explicitlyreturn true
in the script.