search

rawls238 / PlanOut.js

A JavaScript port of Facebook's PlanOut Experimentation Framework
MIT License
308 stars 52 forks source link

Running interpreter on an experiment should set `this._inExperiment = true` if no `return` is run #79

Open dobesv opened 4 years ago

dobesv commented 4 years ago

I believe the PlanOut language expects that if you don't return false then the experiment is considered active.

Currently the interpreter only sets _inExperiment = true if you explicitly return true in the script.

rawls238 commented 4 years ago

Seems reasonable, feel free to PR

eytan commented 4 years ago

Yes, at some point we eliminated the magic variable, in experiment. Returning false is the way folks should be disabling logging.

Sent from my iPhone

On Jan 24, 2020, at 5:55 PM, Dobes Vandermeer notifications@github.com wrote:

 I believe the PlanOut language expects that if you don't return false then the experiment is considered active.

Currently the interpreter only sets _inExperiment = true if you explicitly return true in the script.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.