rawls238 / PlanOut.js

A JavaScript port of Facebook's PlanOut Experimentation Framework
MIT License
308 stars 52 forks source link

No longer loads with webpack 5 #88

Closed gita-vahdatinia closed 3 years ago

gita-vahdatinia commented 3 years ago

Bug report

I have an issue with planout that bundled fine with Webpack 4 but no longer works with Webpack 5.

What is the current behavior? Module is not loaded:

Uncaught TypeError: Getter must be a function: A
    at Function.defineProperty (<anonymous>)
    at Function.__webpack_require__.d (bundle.js:963)
    at eval (index.js:2)
    at Module../build/index.js (planout.js:102)
    at __nested_webpack_require_539__ (planout.js:25)
    at eval (planout.js:89)
    at eval (planout.js:92)
    at webpackUniversalModuleDefinition (planout.js:3)
    at eval (planout.js:5)
    at Object../node_modules/planout/dist/planout.js (bundle.js:291)

If the current behavior is a bug, please provide the steps to reproduce. Repo Here:

https://github.com/gita-v/webpack_issue

What is the expected behavior?

For module to load :)

Other relevant information: webpack version: 5.3.2 Node.js version: 14.14.0

rawls238 commented 3 years ago

Thanks for reporting this! Will look into it

gita-vahdatinia commented 3 years ago

I am trying to debug as well and am having issue running jest tests; I keep getting No tests found error.. Is there something I have to update to be able to run the tests. Nevermind, figured out my jest issue.

gita-vahdatinia commented 3 years ago

Please review whenever you have the chance 😄

https://github.com/rawls238/PlanOut.js/pull/90

rawls238 commented 3 years ago

Closed by #90

rawls238 commented 3 years ago

pushed to npm