rawrtc / rawrtc-data-channel

A standalone WebRTC and ORTC data channel implementation.
BSD 2-Clause "Simplified" License
52 stars 6 forks source link

GCC7.1 usrsctp compilation errors #2

Closed murillo128 closed 5 years ago

murillo128 commented 6 years ago

I am hitting this issue:

https://github.com/sctplab/usrsctp/issues/149

Could it be possible to update the dependency to include the fix?

lgrahl commented 6 years ago

Was tracked in https://github.com/rawrtc/rawrtc/issues/68 and @dbrgn posted a workaround (https://github.com/rawrtc/rawrtc/issues/68#issuecomment-326774904).

Blocked by https://github.com/NEAT-project/usrsctp-neat/issues/10

murillo128 commented 6 years ago

Patched the .sh as suggested on the other issue:

diff --git a/make-dependencies.sh b/make-dependencies.sh
index fe842eb..cd1735f 100755
--- a/make-dependencies.sh
+++ b/make-dependencies.sh
@@ -75,6 +75,8 @@ if [ -z "$SKIP_USRSCTP" ]; then
     fi
     git checkout ${USRSCTP_BRANCH}
     git reset --hard ${USRSCTP_COMMIT}
+    echo ${USRSCTP_PATH}
+    sed -i 's/SCTP_DIAG_INFO_LEN 64/SCTP_DIAG_INFO_LEN 512/'  usrsctplib/netinet/sctp_constants.h
     cd ${MAIN_DIR}
 fi

Due to submodules 128 was even small for me :)

lgrahl commented 6 years ago

We should probably add the patch to this project until the issue has been resolved.

lgrahl commented 5 years ago

Resolved by #28