search

rawsonj / triviabot

A simple IRC trivia bot written in python using twisted.
GNU General Public License v3.0
41 stars 51 forks source link

Issue 55 #63

Closed rawsonj closed 8 years ago

rawsonj commented 8 years ago

Hey Andy, I implemented #55 in this PR with what I was thinking of when I made the comment that we could encapsulate this change all inside of the answer.py file.

Please review and let me know what you think.

Joe

andy5995 commented 8 years ago

You're asking me to review your code? Do you remember when I said I started learning python only recently?

I appreciate your confidence in me, but, to be honest, I don't really understand very well what I'm looking at yet. But that's okay. If it works, lets use it. Have you tested it yet?

Update: I activated this version in #triviabot on QuakeNet

rawsonj commented 8 years ago

I know you're learning, that's kind of the point.

And regardless of experience level, it's good practice to have someone look over what you did and make sure there's no obvious issues.

I'll go-ahead and merge this pull request and delete the branch.

andy5995 commented 8 years ago

I know you're learning, that's kind of the point.

And regardless of experience level, it's good practice to have someone look over what you did and make sure there's no obvious issues.

Makes sense.

I'll go-ahead and merge this pull request and delete the branch.

The branch is still showing. I wonder if that's related to the same problem I had. First I used 'git branch -D issue55', then saw I should have used -r. So I did that, but was told there was no remote branch called issue55. But it still showed when I looked at the project page. Then I opened git-cola, and used the option in there to delete the remote branch; and it worked.