Wrap up - Githubissues

rax-maas / blueflood-carbon-forwarder

Forwards pickled messages from carbon to Blueflood

Other

3 stars 8 forks source link

Wrap up #16

Closed izrik closed 8 years ago

izrik commented 8 years ago

This PR adds:

an option to specify a config file, in addition to or instead of command-line parameters
documentation on various failure scenarios
documentation on possible security vulnerabilities

izrik commented 8 years ago

@shintasmith @ChandraAddala @VinnyQ Please review. I have one last change to make: I have to update the info on 207 response code, due to @VinnyQ 's PR #15 .

shintasmith commented 8 years ago

Other that the ones I mentioned, the PR looks good. 👍 Thanks, @izrik for doing this!

izrik commented 8 years ago

@shintasmith @ChandraAddala Did you have any other comments? Did my responses help?

ChandraAddala commented 8 years ago

shintasmith commented 8 years ago

Other than the broken URI, everything else looks good 👍 . You can merge after you fix it.

izrik commented 8 years ago

@shintasmith Done.

shintasmith commented 8 years ago

lgtm 👍 . Please increment the version and upload the new version to PyPi. You can merge this one in :-)