twistd plugin not installed

rax-maas / blueflood-carbon-forwarder

Forwards pickled messages from carbon to Blueflood

Other

3 stars 8 forks source link

twistd plugin not installed #2

Open glyph opened 9 years ago

glyph commented 9 years ago

The only package included in graphite-blueflood by its setup.py is bluefloodserver. The only data file is README.md. The twistd plugin in twisted/plugins is, therefore, not packaged.

This is an unfortunately remarkably subtle thing to do completely correctly, but it basically boils down to this:

from setuptools import setup, find_packages
setup(
    # ...
    packages=find_packages(exclude=[]) + ["twisted.plugins"],
    # ...
)

goru97 commented 9 years ago

Hi Glyph! I made the changes to setup.py. I guess we can close this issue now.

glyph commented 9 years ago

Where were the changes? We should close the issue once there is a test on master and continuous integration to verify that it works ;).

goru97 commented 9 years ago

@glyph Added tox.ini for tests and .travis.yml for integrating it with Travis-CI. The builds were successful with push and pull-request. Here's a PR for reference https://github.com/rackerlabs/blueflood-carbon-forwarder/pull/5.

glyph commented 9 years ago

Looks good to me!

glyph commented 9 years ago

It seems that some tests for loading the plugin are still in order though?