rax-maas / dreadnot

deploy without dread
Apache License 2.0
631 stars 61 forks source link

fix(pagerduty) #102

Closed kaustavha closed 8 years ago

kaustavha commented 8 years ago

fix for pagerduty, use algo from before in leui of changing the url at the source

phoebesimon commented 8 years ago

@kaustavha can you explain more in the description why the change is necessary?

just so I'm clear: this change ensures that the url is formatted using the hostname and port instead of the host

kaustavha commented 8 years ago

@phoebesimon So the last working version of this file was: https://github.com/racker/dreadnot/blob/c00b82b87bd34e120b606c21ad51a2150b95d275/lib/util/pagerduty.js#L33 And it uses url to format the url. Sort of a random dart, but yea, remove any default host and reencode.

mburns commented 8 years ago

:+1: