search

rax-maas / dreadnot

deploy without dread
Apache License 2.0
631 stars 61 forks source link

Make forcing the build configurable for Jenkins #32

Closed mynnx closed 10 years ago

mynnx commented 12 years ago

We have a development pipeline in which Dreadnot is the final step - we don't want it to create Jenkins builds, we want it to deploy as a result of Jenkins builds. This keeps the original behavior, but allows us to turn the behavior of "no revision was found, force a build" off.

philips commented 11 years ago

@mynnx Is this PR still valid?

tildedave commented 11 years ago

I would still like this functionality, whether or not this code ends up being the right fix for the solution. We use a number of jenkins jobs to certify a commit hash and triggering a build by default doesn't make much sense for this use case.

One possibility, rather than this approach, would be that if attempts is set to 0, no trigger is done and the deploy just fails (?).

russellhaering commented 10 years ago

I'm fine with this, merging.