search

rax-maas / dreadnot

deploy without dread
Apache License 2.0
631 stars 61 forks source link

Add 'error' handler on the request object. #47

Closed Kami closed 11 years ago

Kami commented 11 years ago

Currently there is no handler for error event in the logger middleware which means dreadnot will crash because of uncaught exception if for some reason we can't send response to the client (res.end emits an error).

Here is an example error which happened to me multiple times already:

        throw arguments[1]; // Unhandled 'error' event
                       ^
Error: socket hang up
    at createHangUpError (http.js:1360:15)
    at ServerResponse.OutgoingMessage._writeRaw (http.js:507:26)
    at ServerResponse.OutgoingMessage._send (http.js:476:15)
    at ServerResponse.OutgoingMessage.write (http.js:740:18)
    at ServerResponse.OutgoingMessage.end (http.js:882:16)
    at ServerResponse.module.exports.res.end (/opt/dn-bundle-f3231027f10bfb27a1098e2752a9fb485e19dcfd/lib/web/middleware/logger.js:38:11)
    at res.end (/opt/dn-bundle-f3231027f10bfb27a1098e2752a9fb485e19dcfd/node_modules/connect/lib/middleware/session.js:282:15)
    at /opt/dn-bundle-f3231027f10bfb27a1098e2752a9fb485e19dcfd/node_modules/connect/lib/middleware/session/memory.js:75:11