rax-maas / dreadnot

deploy without dread
Apache License 2.0
630 stars 61 forks source link

Add support for toggling notifications for nagios by servicegroups #52

Closed dlobue closed 11 years ago

dlobue commented 11 years ago

Support toggling alerts by nagios servicegroups as well as hostgroups. Also updated log messages to indicate whether alerts are being disabled for a servicegroup or hostgroup.

Lastly updated comments to reflect that host notifications are NOT disabled along with service notifications.

dlobue commented 11 years ago

Added it to the file comment.

bison commented 11 years ago

In addition to a comment linking to the Nagios source, why not define constants for these magic numbers that correspond at least roughly to the ones Nagios defines.

dlobue commented 11 years ago

@bison because there's over a hundred of them, we're only using 4, and I'm kinda going for MVP as I'm under a deadline.

robert-chiniquy commented 11 years ago

Does sound like a good idea for another PR though (or at least an issue opened to track that idea)

lakshmi-kannan commented 11 years ago

I wish we could have test cases. We'll need to have a mock nagios service I guess.

Code LGTM. +1.

dlobue commented 11 years ago

works in staging.