rax-maas / dreadnot

deploy without dread
Apache License 2.0
631 stars 61 forks source link

feat(cloud monitoring): add support for cloud monitoring suppressions #62

Closed simonvetter closed 10 years ago

simonvetter commented 10 years ago

This adds support for Cloud Monitoring suppressions.

It provides a couple of basic functions:

simonvetter commented 10 years ago

in most cases, you would set up your dreadnot stacks so that the suppression is actually only created after both build and integration test phases have completed.

You'd think you should be able to set a suppression for 3+ hrs just to be safe, but in case your deploy fails, your DN stack won't execute entirely and you run the risk of leaving an active suppression on an entire DC behind. By making them expire after 30 mins, you make sure that even if you set a suppression that won't get deleted, it will still expire fairly shortly.

I guess the 30 min limit is rather arbitrary and depends on how long your deploy take, which is why you can always set an endTime of your choice from your DN stack (i.e. this is just a default used if you do not specify endTime, or an endTime of 0).

rphillips commented 10 years ago

+1

ynachiket commented 10 years ago

thanks for doing this .. the lights would be happy now :)