chore(auth)

[kaustavha]

Fix/clean/rebase pr for ldap and modularizing the auth module more This is a clone of #66 without their newrelic mods since a newer newrelic based mod exists on our master, cleaned up, reviewed, and configured to preserve backwards compatibility better.

• Auth section is now abstracted out into separate auth handlers (htpasswd, passthru, ldap)
• Implentation of LDAP auth (using ldapauth npm module)
• Configuration (local_settings) can be used to choose which auth_method to use

[mburns]

@kaustavha ping

[kaustavha]

@mburns pong

[kaustavha]

Right so:

• I forgot to add the ldap dep from the original pr in the package.json of this pr, when i added it the build started to fail on all versions of node above 0.10
• I support the refactor of the auth module, it cleans it up and makes it more modular
• It is currently out of scope to add ldap auth via this pr because the library it depends on is uh not good because:
  • It's old and dead, not touched since 2013 https://github.com/trentm/node-ldapauth/commits/master
  • It relies on a git sha of another ldap library which imo is a little sketchy https://github.com/trentm/node-ldapauth/blob/master/package.json#L21
  • It relies on an ancient version of bcrypt which causes the build failures on node >v0.10 https://github.com/trentm/node-ldapauth/blob/master/package.json#L20 https://github.com/dcodeIO/bcrypt.js

I propose we scrap the ldap portion of this PR and merge in the auth module refactor, create an issue for ldap integration and revisit it in the future.

[mburns]

I propose we scrap the ldap portion of this PR and merge in the auth module refactor, create an issue for ldap integration and revisit it in the future.

@kaustavha ok, let's do that then and wrap this up. I'd like to land these improvements.

[kaustavha]

That should do it.

[mburns]

(doesn't work in staging)