search

ray-cw / roll20-CPR-charactersheet

A Roll 20 character sheet for Cyberpunk RED.
10 stars 5 forks source link

Weapon attack rolls not pulling skill base correctly #8

Open Kookiemons opened 3 years ago

Kookiemons commented 3 years ago

Can't tell exactly what is causing the problem but some are pulling incorrect modifiers and others are ignoring stat and pulling only the skill. Not replicating constantly across different character sheets.

KalevraCP commented 3 years ago

I second this. It happens with Assault Rifles and Melee specifically. They are taking Melee weapons and Dex into account, instead of their respective skill. You can test this by creating a blank character sheet and just putting points into Dex and Melee Weapons and trying out the attack macros.

You can sort of circumvent this by selecting a different weapon type, and then switching back, not rolling and reloading the page, but it's a very convoluted process.

Another issue is that it "remembers" the values, so if you assign a new point to the skill, the old skill value is still used.

The sheet is great, but this is a critical funnel issue.

Oh, and sidescrolling please!!!! :)

Thanks!

Airylan commented 3 years ago

+1.

For @ray-cw "Assault Rifle" is missing from the switch on line 1616. For the "remembering" the values, could the @{total_Skill} value be used? (I don't know how to test Roll20 sheets or I'd just submit a PR).

I'm also seeing "Brawling" missing from both lists.

daxxom commented 3 years ago

This is happening to my group as well. Particularly frustrating when you have to constantly switch everyone's weapons and reload the page to fix.