Addon is installable in older Firefox versions (52esr, >=48.0), but does not correctly switch the UA - Githubissues

ray-lothian / UserAgent-Switcher

A User-Agent spoofer browser extension that is highly configurable

https://webextension.org/listing/useragent-switcher.html

Mozilla Public License 2.0

884 stars 142 forks source link

Addon is installable in older Firefox versions (52esr, >=48.0), but does not correctly switch the UA #171

Open wesinator opened 1 year ago

wesinator commented 1 year ago

I hope you're doing well.

As a heads up: So the mv2 version of this addon currently installs in Firefox back to version 48 (the earliest version to support most mv2 features).

I tested 0.4.9 on FF 52.9.0esr on Windows 7. The addon installs from AMO successfully, and the page action UI to select and change the user agent works, but it doesn't actually change the user-agent.

Error (0.4.9 on 52.9.0esr):

o is undefined https://github.com/ray-lothian/UserAgent-Switcher/blob/70a5affd378480069f7248321475f4478f3c966f/v2/firefox/data/popup/index.js#L397

Solutions

Set a strict_min_version to restrict addon installs to the oldest version of Firefox where the functionality actually works.
Add a check in code for older versions of FF, and use supported API/config to change the user-agent on those versions.