search

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
1.3k stars 415 forks source link

[Feature] Serve gRPC health check #1554

Open GeneDer opened 1 year ago

GeneDer commented 1 year ago

Search before asking

Description

Since Ray 2.7.0 Serve have offered gRPC support through proxy. We are currently only checking the health check on the HTTP proxy. This might not be reflect to the heath on the gRPC proxy if we offer to not start HTTP proxy together with gRPC proxy. Let's add a new gRPC client to health check gRPC proxy iff gRPC on serve is enabled.

Use case

When user start Serve with only gRPC proxy.

Related issues

https://github.com/ray-project/kuberay/issues/1107

Are you willing to submit a PR?

kevin85421 commented 1 year ago

Is this issue same as https://github.com/ray-project/kuberay/issues/694? If so, I will close #694.

GeneDer commented 1 year ago

Yes, I think the idea is the same to use gRPC in health check.