search

ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
1.14k stars 367 forks source link

[Feature] Should we stop publishing images on DockerHub? #1924

Open kevin85421 opened 7 months ago

kevin85421 commented 7 months ago

Search before asking

Description

KubeRay CI publishes images to both Quay and DockerHub. However, the DockerHub bot has somehow been removed from the KubeRay DockerHub account, causing KubeRay CI to fail when pushing images to DockerHub. To unblock it, I opened #1923 and #1926 as a workaround.

I have already decided to use Quay as the default image registry for KubeRay v1.1.0 because (1) it doesn't have pull limit (2) it has more usage log. Therefore, I am currently considering whether we should still publish images on DockerHub or not.

Any thoughts? cc @andrewsykim @astefanutti @anishasthana

Use case

No response

Related issues

No response

Are you willing to submit a PR?

astefanutti commented 7 months ago

+1

It'd be useful to have a warning in the release notes so existing users can adjust their existing deployment if needed.

anishasthana commented 7 months ago

I'm a +1 to this as well but perhaps we should stagger it a release? At least to give users some time to adjust.

andrewsykim commented 7 months ago

No objections to make quay the default and to stop publishing nighlty images through CI. But do we really have to remove dockerhub support entirely? Can we still publish to dockerhub only on tagged releases?

kevin85421 commented 7 months ago

Thank you for the feedback! I will try to reach out to our CI/Security teams to set it up the DockerHub back, but I think it may be a long process.