ray-project / kuberay

A toolkit to run Ray applications on Kubernetes
Apache License 2.0
1.01k stars 341 forks source link

chore: remove ConfigMap from ray-job.kueue-toy-sample.yaml #1976

Closed kevin85421 closed 4 months ago

kevin85421 commented 4 months ago

Why are these changes needed?

https://github.com/ray-project/kuberay/pull/1956#discussion_r1511337275

This PR removes ConfigMap from the YAML. In this doc, we need to run kubectl create -f ray-job.kueue-toy-sample.yaml multiple times. If the YAML includes a ConfigMap, users may see a warning message indicating that the ConfigMap already exists. Removing the ConfigMap improves the UX.

Related issue number

Checks

kevin85421 commented 4 months ago

cc @andrewsykim

andrewsykim commented 4 months ago

LGTM, my other comments are not blocking